search

openlawteam / tribute-contracts

A new modular DAO framework, inspired by the Moloch smart contracts
https://tributedao.com
MIT License
295 stars 109 forks source link

fix-02: reset grace period if is a tie #508

Closed fforbeck closed 2 years ago

fforbeck commented 2 years ago

If a new vote result is submitted and it changes the result status from PASS to TIE, the grace period is not reset. A TIE should not be treated as the same as a NOT_PASS, otherwise any member can abuse it to deny vote proposals before execution.

Proposed Changes

codecov[bot] commented 2 years ago

Codecov Report

Merging #508 (e526ef6) into master (bef1c72) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #508   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files          53       53           
  Lines        1851     1851           
  Branches      430      430           
=======================================
  Hits         1523     1523           
  Misses        328      328
Impacted Files Coverage Δ
contracts/adapters/voting/OffchainVoting.sol 41.25% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bef1c72...e526ef6. Read the comment docs.