search

openlawteam / tribute-contracts

A new modular DAO framework, inspired by the Moloch smart contracts
https://tributedao.com
MIT License
295 stars 109 forks source link

feat: New Adapter - Manager #541

Closed nickmzero closed 2 years ago

nickmzero commented 2 years ago

Proposed Changes

Adds the Manager adapter which allows DAO operators to update adapters/extensions/configs by submitting an EIP712 signature along with the proposal, skipping the existing proposal/voting process

codecov[bot] commented 2 years ago

Codecov Report

Merging #541 (710d7d1) into master (58f7016) will increase coverage by 0.22%. The diff coverage is 100.00%.

:exclamation: Current head 710d7d1 differs from pull request most recent head 7319141. Consider uploading reports for the commit 7319141 to get more accurate results

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   90.72%   90.95%   +0.22%     
==========================================
  Files          52       53       +1     
  Lines        1866     1912      +46     
  Branches      438      448      +10     
==========================================
+ Hits         1693     1739      +46     
  Misses        173      173
Impacted Files Coverage Δ
contracts/adapters/Manager.sol 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 58f7016...7319141. Read the comment docs.

nickmzero commented 2 years ago

@nickmzero it looks very good. I added some minor comments about the tests and suggestion about adding the proposalId as part of the signature.

@fforbeck thanks. I've added proposalId to the signature and updated the descriptions of those tests