openlawteam / tribute-contracts

A new modular DAO framework, inspired by the Moloch smart contracts
https://tributedao.com
MIT License
297 stars 110 forks source link

feat: update KycOnboarding to allow for top ups, update Manager to allow for config-only updates #543

Closed nickmzero closed 2 years ago

nickmzero commented 2 years ago

KycOnboarding.sol changes:

Manager.sol changes:

codecov[bot] commented 2 years ago

Codecov Report

Merging #543 (01f7380) into master (3ab7ea3) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
+ Coverage   90.95%   90.97%   +0.01%     
==========================================
  Files          53       53              
  Lines        1912     1916       +4     
  Branches      448      449       +1     
==========================================
+ Hits         1739     1743       +4     
  Misses        173      173              
Impacted Files Coverage Δ
contracts/adapters/KycOnboarding.sol 93.58% <100.00%> (+0.25%) :arrow_up:
contracts/adapters/Manager.sol 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ab7ea3...01f7380. Read the comment docs.

nickmzero commented 2 years ago

It looks great @nickmzero ! I added some comments and questions about the top up and the new update type.

@fforbeck Pushed these changes: