openlawteam / tribute-contracts

A new modular DAO framework, inspired by the Moloch smart contracts
https://tributedao.com
MIT License
295 stars 109 forks source link

Remove manager proposalId #552

Closed nickmzero closed 2 years ago

nickmzero commented 2 years ago

Proposed Changes

codecov[bot] commented 2 years ago

Codecov Report

Merging #552 (0952191) into master (167b522) will decrease coverage by 0.15%. The diff coverage is 40.00%.

:exclamation: Current head 0952191 differs from pull request most recent head ffce2a6. Consider uploading reports for the commit ffce2a6 to get more accurate results

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
- Coverage   90.98%   90.82%   -0.16%     
==========================================
  Files          53       53              
  Lines        1918     1919       +1     
  Branches      449      449              
==========================================
- Hits         1745     1743       -2     
- Misses        173      176       +3     
Impacted Files Coverage Δ
contracts/core/DaoRegistry.sol 96.79% <0.00%> (-1.05%) :arrow_down:
contracts/adapters/Manager.sol 97.82% <66.66%> (-2.18%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.