openlawteam / tribute-contracts

A new modular DAO framework, inspired by the Moloch smart contracts
https://tributedao.com
MIT License
295 stars 109 forks source link

feat: TF-198 TributeERC721 #566

Closed nickmzero closed 1 year ago

nickmzero commented 1 year ago

Proposed Changes

Adds:

codecov[bot] commented 1 year ago

Codecov Report

Merging #566 (06ec6ea) into master (43bd921) will increase coverage by 0.12%. The diff coverage is 94.73%.

:exclamation: Current head 06ec6ea differs from pull request most recent head f15d772. Consider uploading reports for the commit f15d772 to get more accurate results

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   90.46%   90.59%   +0.12%     
==========================================
  Files          53       54       +1     
  Lines        1941     1998      +57     
  Branches      449      459      +10     
==========================================
+ Hits         1756     1810      +54     
- Misses        185      188       +3     
Impacted Files Coverage Δ
contracts/nft/TributeERC721.sol 94.73% <94.73%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jdville03 commented 1 year ago

@nickmzero @adridadou can we get all checks to pass before merging this?

nickmzero commented 1 year ago

@nickmzero @adridadou can we get all checks to pass before merging this?

I'll add some more tests on what's not covered