openlawteam / tribute-ui

Tribute - A modular DAO framework developed and coordinated by its members
https://demo.tributedao.com
Apache License 2.0
45 stars 40 forks source link

Detect network EIP-1559 support; conditionally add `gasPrice` #458

Closed jtrein closed 3 years ago

jtrein commented 3 years ago

With our current updates to remove legacy tx support by removing the gasPrice field, and also updating our Web3 library, we have broken tx's for Trezor and Ledger wallets using MetaMask. This is expected behaviour, as stated by MetaMask, but we should detect EIP-1559 support and conditionally set the gasPrice field exactly as we used to if no EIP support was detected.

References: