search

openlayers / ol2

OpenLayers v2 - deprecated!
Other
1.48k stars 770 forks source link

Accessibility enhancements in my fork #385

Open mgifford opened 12 years ago

mgifford commented 12 years ago

I've made some enhancements to the accessibility here - https://github.com/mgifford/openlayers

Would like to work on this a bit more. Would like to know though if it's too late for 2.12 and also what your process is for considering patches. I'm not a javascript developer, but have been working things out slowly.

So what's the community process around this codebase?

marcjansen commented 12 years ago

Hi @mgifford and welcome to OpenLayers.

Your participation on the project is always welcome. To contribute code we need to have a CLA see http://trac.osgeo.org/openlayers/wiki/HowToContribute#ContributorsLicenseAgreements from you.

To give your enhancements back to the community, pull requests from a specific branch of your OpenLayers fork work best. All new features ahould have tests... and code changes should not break existing tests. When you think your branch is reviewable, issue the pull request, and one of the OpenLayers developers will likely review it. If all is well, your changes are going to be merged into the master branch.

It is probably too late for your changes to appear in 2.12, as the release process has already started. Eric Lemoine, @elemoine , is this releases manager... he decides in the end. Btw see #223 for recent changes with accesibility in mind.

I hope this'll get you started.

mgifford commented 12 years ago

I'd seen the issue in #223. And yes, this is definitely getting me along the right path.

mgifford commented 12 years ago

I've emailed back in the Contributors License Agreement as per the CLA. It would be too bad if I've missed the deadline for 212.

I don't know where the tests are, but I haven't written any. Like most folks I like that there are tests, but hate writing them. I can try though.

I've got something that works now and gives access to a lot more people. There are some basic accessibility problems with the examples. These need more attention.

tschaub commented 12 years ago

ICLA received. Thanks @mgifford.

mgifford commented 12 years ago

I've got a demo up here finally (at the bottom of the blog post) - http://openconcept.ca/blog/mgifford/openlayers-accessibility-drupal

Thanks for adding me to the list of contributors.

Would like to get some feedback from folks who really know OpenLayers about the changes I've suggested. So far they seem to work.

mgifford commented 11 years ago

Would be great if there could be some movement on getting these ideas into the next release. What's the timeline for 2.13?