Track "configuration dirty" to control call to CdiPanel.runUpdateComplete()

openlcb / OpenLCB_Java

Java implementation of OpenLCB / LCC protocols. This implementation operates inside JMRI, and can also be used inside Android apps.

6 stars 9 forks source link

Track "configuration dirty" to control call to CdiPanel.runUpdateComplete() #150

Closed atanisoft closed 3 years ago

atanisoft commented 5 years ago

While it is useful for the CdiPanel to trigger runUpdateComplete() automatically on close, the code in runUpdateComplete() should only send the datagram if the config has in fact been updated and written to the node. This currently leads to the OpenMRN ConfigUpdateListener::apply_configuration method to be called even if the config hasn't been updated which could be considered an unintended behavior.

petecressman commented 4 years ago

Fix pending in PR #161

balazsracz commented 3 years ago

Fixed by #178