Fixes incorrect handling of string fields that are more than 64 characters long.

openlcb / OpenLCB_Java

Java implementation of OpenLCB / LCC protocols. This implementation operates inside JMRI, and can also be used inside Android apps.

6 stars 9 forks source link

Fixes incorrect handling of string fields that are more than 64 characters long. #157

Closed balazsracz closed 5 years ago

balazsracz commented 5 years ago

Fixes incorrect handling of string fields that are more than 64 characters long.

Previously this has created a "jumbo" datagram that is not standards compliant.

Testing improvements:

Adds tests for long and short string writes including clipping and correct zero termination.
Finishes a half-implemented test in the Config Rep area.
Fixes warnings emitted by test.

coveralls commented 5 years ago

Coverage increased (+0.4%) to 71.803% when pulling 15f24b1eaf6a2934a70359e233ab35a525d154bb on bracz-memcfg-write-long into 2166183945f237febb3ae93ee898ec14d84de99e on master.