search

openlcb / OpenLCB_Java

Java implementation of OpenLCB / LCC protocols. This implementation operates inside JMRI, and can also be used inside Android apps.
6 stars 9 forks source link

Upgrades to CdiPanel configuration #161

Closed petecressman closed 4 years ago

petecressman commented 4 years ago

Implement closing dialog to let user go back and write changes. Remind user to save panel when sensor or turnout is made. Enable/disable 'Write All' button (formerly Save changes button) according to whether saves are needed. Suppress 'end update' message when no changes have been made. Fix create sensor/turnout titled panel. Set Collapse panels title to bold. Set default directory for backup and restore to user's choice of file location in preferences.

atanisoft commented 4 years ago

There appears to be some whitespace consistency issues in the updated CdiPanel.java file. It would be good to clean this up prior to merge.

pabender commented 4 years ago

Closing and opening to see if the CI build runs.

pabender commented 4 years ago

There appears to be an issue with the configuration on Travis that crept up since the last PR on the repo. Let me fix that so CI completes before we put this in.

petecressman commented 4 years ago

The problem might be with a mal-formed panel file that I have used as a negative test for some of my error checking in Circuit Builder. (SignalMast with a bad system name). If this is the problem, I can delete the offending mast in the file.

petecressman commented 4 years ago

It's Apveyor with that problem. I think CI needs me to do something about maven. I will get to that soon.

pabender commented 4 years ago

@petecressman i checked the logs on Travis. There is a configuration error there before it even gets to the maven build.

In other words, it isn’t even getting to maven to build your code.

petecressman commented 4 years ago

Withdraw this PR until those who asked me to do this have reviewed it.