Fix spotbugs warnings - Githubissues

openlcb / OpenLCB_Java

Java implementation of OpenLCB / LCC protocols. This implementation operates inside JMRI, and can also be used inside Android apps.

6 stars 9 forks source link

Fix spotbugs warnings #165

Closed rjoachim closed 4 years ago

rjoachim commented 4 years ago

Fix most of the spotbugs warnings. Some warnings in tests could not be fixed and are now suppressed. In the classes touched I also fixed warnings of eclipse IDE and improved code formatting.

Following classes needed bigger changes:

MimicNodeStore (Timer handling)
NIDaAlgorithm (Timer handling)
OptionalIntRejectedMessage (deprecated getMti(), introduced getRejectMTI())
Util.waitForPropertyChange() (improve wait/notify)
TimeKeeper (refactoring)

coveralls commented 4 years ago

Coverage decreased (-0.03%) to 71.792% when pulling 10f9c11a9254767f93d61c1e618a9aeb255609f7 on rjoachim:rj-cleanup_spotbugs_warnings into 70479bf888595dc44b5bd90701e7c40c11ce12bc on openlcb:master.