openlcb / OpenLCB_Java

A git-managed copy of the SVN-based Java prototype implementation of OpenLCB. This implementation operates inside JMRI.
6 stars 9 forks source link

LCC Hub IP address only shows localhost #207

Closed bakerstu closed 1 year ago

bakerstu commented 1 year ago

Verified in JMRI 5.0+Rc441642522 running under Ubuntu 20.04.

After starting an LCC Hub (LCC->Start Hub), a window pops open that shows the "Hub IP address", but only shows "127.0.1.1:12021". Actually, this is not even the correct "localhost" because that would be 127.0.0.1. I'm not sure where 127.0.1.1 is actually coming from.

It would be much more valuable for the user if the window listed (all of) the host IP address(s) and port numbers similar to what the WiThrottle Server window does.

I'm not sure if this logic is resides in this repo or in the JMRI repo.

image
bakerstu commented 1 year ago

One more thing I noticed is that the title of the window is "OpenLCB" even though the connection type is LCC. This is otherwise fine, but it may confuse some users that don't know what OpenLCB is. Should it be changed it to "LCC/OpenLCB Hub Control"?

dpharris commented 1 year ago

I will have a look around and see if I can improve things.

David

On Sat, Oct 1, 2022 at 1:31 PM Stuart W Baker @.***> wrote:

One more thing I noticed is that the title of the window is "OpenLCB" even though the connection type is LCC. This is otherwise fine, but it may confuse some users that don't know what OpenLCB is. Should it be changed it to "LCC/OpenLCB Hub Control"?

— Reply to this email directly, view it on GitHub https://github.com/openlcb/OpenLCB_Java/issues/207#issuecomment-1264473747, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEDQSXJ5VZ6BXRKVHAY6PTWBCNTHANCNFSM6AAAAAAQ2TASQU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

RobertPHeller commented 1 year ago

At Sat, 01 Oct 2022 13:29:47 -0700 openlcb/OpenLCB_Java @.***> wrote:

Verified in JMRI 5.0+Rc441642522 running under Ubuntu 20.04.

After starting an LCC Hub (LCC->Start Hub), a window pops open that shows the "Hub IP address", but only shows "127.0.1.1:12021". Actually, this is not even the correct "localhost" because that would be 127.0.0.1. I'm not sure where 127.0.1.1 is actually coming from.

I believe that all 127.0.0.0/8 addresses work for localhost and connect to the loopback network device.

It would be much more valuable for the user if the window listed (all of) the host IP address(s) and port numbers similar to what the WiThrottle Server window does.

I'm not sure if this logic is resides in this repo or in the JMRI repo.

image

-- Robert Heller -- Cell: 413-658-7953 GV: 978-633-5364 Deepwoods Software -- Custom Software Services http://www.deepsoft.com/ -- Linux Administration Services @.*** -- Webhosting Services

balazsracz commented 1 year ago

We should do the same thing as JMRI does for the withrottle window, which lists all local interfaces with their IP addresses.

bobjacobsen commented 1 year ago

The JMRI code for WiThrottle is near line 100 in java/src/jmri/jmrit/withrottle//UserInterface.java

dpharris commented 1 year ago

Bob --

Thanks, this is helpful.

David

On Sun, Oct 2, 2022 at 6:37 AM Bob Jacobsen @.***> wrote:

The JMRI code for WiThrottle is near line 100 in java/src/jmri/jmrit/withrottle//UserInterface.java

— Reply to this email directly, view it on GitHub https://github.com/openlcb/OpenLCB_Java/issues/207#issuecomment-1264646182, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEDQSSRRO4BKDYWESWEHDDWBGFZPANCNFSM6AAAAAAQ2TASQU . You are receiving this because you commented.Message ID: @.***>

bobjacobsen commented 1 year ago

The JMRI code that displays the hub address is in java/src/jmri/jmrix/openlcb/swing/hub/HubPane.java and the title is set in java/src/jmri/jmrix/openlcb/swing/hub/HubAction.java

icklesteve commented 1 year ago

Hi @dpharris I'm having a look at the Hub swing code in JMRI so can sort unless you're close?

I'm also thinking appending the connection / disconnection messages from the Hub into a scrollable list would be a nice mini update ;-)

Steve.

dpharris commented 1 year ago

Steve --

Go ahead. I have pulled my horns in at the moment for other changes.

David

On Sun, Oct 23, 2022 at 6:23 PM Steve Young @.***> wrote:

Hi @dpharris https://github.com/dpharris I'm having a look at the Hub swing code in JMRI so can sort unless you're close?

I'm also thinking appending the connection / disconnection messages from the Hub into a scrollable list would be a nice mini update ;-)

Steve.

— Reply to this email directly, view it on GitHub https://github.com/openlcb/OpenLCB_Java/issues/207#issuecomment-1288280290, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEDQST5AFYPEIC3CMWAXQLWEXQJLANCNFSM6AAAAAAQ2TASQU . You are receiving this because you were mentioned.Message ID: @.***>

icklesteve commented 1 year ago

Hi @bakerstu

There have been some tweaks in this area in JMRI 5.3.4 If you could confirm this now displays as expected?

Thanks, Steve.

bobjacobsen commented 1 year ago

Here's what it looks like now:

image

icklesteve commented 1 year ago

See https://github.com/JMRI/JMRI/pull/11902 which adds the LinkLocal connection, missed on previous update.

dpharris commented 1 year ago

Should we include a line that indicates that it is advertised as " openlcbcan.local."?

David

On Mon, Apr 3, 2023 at 12:02 PM Steve Young @.***> wrote:

See JMRI/JMRI#11902 https://github.com/JMRI/JMRI/pull/11902 which adds the LinkLocal connection, missed on previous update.

— Reply to this email directly, view it on GitHub https://github.com/openlcb/OpenLCB_Java/issues/207#issuecomment-1494825646, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEDQSUEA4I2TNFYTR6KIPTW7MNDLANCNFSM6AAAAAAQ2TASQU . You are receiving this because you were mentioned.Message ID: @.***>

balazsracz commented 1 year ago

On Mon, Apr 3, 2023 at 9:57 PM David Harris @.***> wrote:

Should we include a line that indicates that it is advertised as " openlcbcan.local."?

I don't think that's necessary. That is an internal name that does not necessarily need to be exposed to the user.

Message ID: @.***>

icklesteve commented 1 year ago

The Bonjour/Zeroconf is also documented at https://www.jmri.org/help/en/html/doc/Technical/Networking.shtml , see the Upstream Connections list.