search

openlcb / OpenLCB_Java

A git-managed copy of the SVN-based Java prototype implementation of OpenLCB. This implementation operates inside JMRI.
6 stars 9 forks source link

Hub Line Endings / GC Serial #208

Closed icklesteve closed 1 year ago

icklesteve commented 1 year ago

Adds constructor option to ignore CR/LF line ends, instead wait for a Gridconnect (GC) Serial Frame, do not send Line Ends. CAN Frame detection for no line endings adapted from JMRI.

Current default behaviour unchanged.

Instead of the boolean flag would it be better to add a Line Feed / GC Serial format constant?

Adds dispose method with boolean flag on while waits. Use try with resources / other tweaks.

bobjacobsen commented 1 year ago

I've tested this with JMRI, LccTools and a CS-105. Works fine. I recommend merging it.