search

openlcb / OpenLCB_Java

Java implementation of OpenLCB / LCC protocols. This implementation operates inside JMRI, and can also be used inside Android apps.
6 stars 9 forks source link

Send AMD at end of alias sequence #224

Closed bobjacobsen closed 1 year ago

bobjacobsen commented 1 year ago

Fix for #121.

See discussion below for further work.

(Note: This commend originally talked about a missing delay between RID and AMD; that's not required by the Standard, so that part of this commented was removed in edit)

balazsracz commented 1 year ago

I re-read the standard and I don't see a requirement that there be a delay between the RID and the AMD frame. From what I can tell they could be back to back on the CAN-bus.

bobjacobsen commented 1 year ago

I re-read the standard and I don't see a requirement that there be a delay between the RID and the AMD frame. From what I can tell they could be back to back on the CAN-bus.

Thanks, you're right. I was mis-remembering where the delay needed to be. Will edit the comment.

bobjacobsen commented 1 year ago

This is in use in JMRI now through a custom .jar file. It would be good to get it merged before the end of May so that we can use a production .jar in the next production JMRI release.