search

openlcb / OpenLCB_Java

Java implementation of OpenLCB / LCC protocols. This implementation operates inside JMRI, and can also be used inside Android apps.
6 stars 9 forks source link

Handle Verify Node Addressed #245

Closed bobjacobsen closed 7 months ago

bobjacobsen commented 7 months ago

This adds support for the Verify Node Addressed message.

As part of that, it renames the various internal references to VerifyNode to be VerifyNodeGlobal

Also armors against AMR messages that don't have a Node ID as content. The Standard says this is required, but some nodes don't send it in response to a collision.

bobjacobsen commented 7 months ago

@dpharris When you get a chance, could you merge this one (and ideally #244 and #246) and then create a new 0.7.34 release of this? Thank you! That'll solve a problem that's been seen by Andrew Crosland when he tries to run under NetBeans.

dpharris commented 7 months ago

Bob -

Will do it later today.

David

On Mon, Feb 19, 2024 at 6:43 AM Bob Jacobsen @.***> wrote:

@dpharris https://github.com/dpharris When you get a chance, could you merge this one (and ideally #244 https://github.com/openlcb/OpenLCB_Java/pull/244 and #246 https://github.com/openlcb/OpenLCB_Java/pull/246) and then create a new 0.7.34 release of this? Thank you! That'll solve a problem that's been seen by Andrew Crosland https://jmri-developers.groups.io/g/jmri/message/9872 when he tries to run under NetBeans.

— Reply to this email directly, view it on GitHub https://github.com/openlcb/OpenLCB_Java/pull/245#issuecomment-1952592917, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEDQSRK7RKDVRXBBNP7DB3YUNQHJAVCNFSM6AAAAABDHFVL4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJSGU4TEOJRG4 . You are receiving this because you were mentioned.Message ID: @.***>