search

openleap / PyLeapMouse

A Leap Motion based mouse in Python
Other
172 stars 65 forks source link

Remove Windows and OSX leap sdk files #3

Closed astagi closed 11 years ago

astagi commented 11 years ago

I think would be better removing all the LeapMotion sdk files from the repository and ask the users to get them from their sdk folder ..

wyager commented 11 years ago

I had it that way originally, but I worry that some people who are less experienced with the SDK and just want to do creative stuff will have a harder time. I mean, it can't hurt anyone to have the sdk files included.

astagi commented 11 years ago

Well you should consider that there are people using x86 or x64 lib :) I had to replace all the files... imho removing win and osx folders and adding some instructions about how to set your environment is a cleaner solution :)

On Tue, Feb 19, 2013 at 5:24 AM, Will Yager notifications@github.comwrote:

I had it that way originally, but I worry that some people who are less experienced with the SDK and just want to do creative stuff will have a harder time. I mean, it can't hurt anyone to have the sdk files included.

— Reply to this email directly or view it on GitHubhttps://github.com/openleap/PyLeapMouse/issues/3#issuecomment-13756385.

Andrea Stagi (@4ndreaSt4gi) - Software Engineer Job profile: http://linkedin.com/in/andreastagi Website: http://4spills.blogspot.it/ Github: http://github.com/astagi

wyager commented 11 years ago

I didn't realize there were multiple libraries. What platform are you using? In my case, I only ever remember having a single library to choose from...

Either way, if there are libraries for other platforms, I would rather add those than get rid of the ones included now. I want this project to be as plug-and-play as possible.

astagi commented 11 years ago

I'm using Windows... yeah there are two version, 32 and 64 bit

On Wed, Feb 20, 2013 at 4:11 AM, Will Yager notifications@github.comwrote:

I didn't realize there were multiple libraries. What platform are you using? In my case, I only ever remember having a single library to choose from...

Either way, if there are libraries for other platforms, I would rather add those than get rid of the ones included now. I want this project to be as plug-and-play as possible.

— Reply to this email directly or view it on GitHubhttps://github.com/openleap/PyLeapMouse/issues/3#issuecomment-13813612.

Andrea Stagi (@4ndreaSt4gi) - Software Engineer Job profile: http://linkedin.com/in/andreastagi Website: http://4spills.blogspot.it/ Github: http://github.com/astagi

wyager commented 11 years ago

Hmm, I will take a look. Does it break if both versions are included in the windows folder?

astagi commented 11 years ago

They can't stay in the same folder, files have the same name in both versions.. if you look in the sdk/lib folder you can verify this by yourself :)

On Wed, Feb 20, 2013 at 4:29 AM, Will Yager notifications@github.comwrote:

Hmm, I will take a look. Does it break if both versions are included in the windows folder?

— Reply to this email directly or view it on GitHubhttps://github.com/openleap/PyLeapMouse/issues/3#issuecomment-13814001.

Andrea Stagi (@4ndreaSt4gi) - Software Engineer Job profile: http://linkedin.com/in/andreastagi Website: http://4spills.blogspot.it/ Github: http://github.com/astagi

astagi commented 11 years ago

I think you've just put 64bit libs, I'm not using python 64bit so it doesn't work if I don't replace libs.. let doing libs copying to an installer, checking the current python version..

On Wed, Feb 20, 2013 at 4:50 AM, Andrea Stagi stagi.andrea@gmail.comwrote:

They can't stay in the same folder, files have the same name in both versions.. if you look in the sdk/lib folder you can verify this by yourself :)

On Wed, Feb 20, 2013 at 4:29 AM, Will Yager notifications@github.comwrote:

Hmm, I will take a look. Does it break if both versions are included in the windows folder?

— Reply to this email directly or view it on GitHubhttps://github.com/openleap/PyLeapMouse/issues/3#issuecomment-13814001.

Andrea Stagi (@4ndreaSt4gi) - Software Engineer Job profile: http://linkedin.com/in/andreastagi Website: http://4spills.blogspot.it/ Github: http://github.com/astagi

Andrea Stagi (@4ndreaSt4gi) - Software Engineer Job profile: http://linkedin.com/in/andreastagi Website: http://4spills.blogspot.it/ Github: http://github.com/astagi

UncleTallest commented 11 years ago

Something else you might want to think about in this regard... There will also be x86 and x86_64 libs for linux at LeapMotion's release. Those would also need to be added in a similar manner as Andrea mentioned. If needed, I'd be more than happy to lend a hand once my leap arrives.

On Tue, Feb 19, 2013 at 10:04 PM, Andrea Stagi notifications@github.comwrote:

I think you've just put 64bit libs, I'm not using python 64bit so it doesn't work if I don't replace libs.. let doing libs copying to an installer, checking the current python version..

On Wed, Feb 20, 2013 at 4:50 AM, Andrea Stagi stagi.andrea@gmail.comwrote:

They can't stay in the same folder, files have the same name in both versions.. if you look in the sdk/lib folder you can verify this by yourself :)

On Wed, Feb 20, 2013 at 4:29 AM, Will Yager notifications@github.comwrote:

Hmm, I will take a look. Does it break if both versions are included in the windows folder?

— Reply to this email directly or view it on GitHub< https://github.com/openleap/PyLeapMouse/issues/3#issuecomment-13814001>.

Andrea Stagi (@4ndreaSt4gi) - Software Engineer Job profile: http://linkedin.com/in/andreastagi Website: http://4spills.blogspot.it/ Github: http://github.com/astagi

Andrea Stagi (@4ndreaSt4gi) - Software Engineer Job profile: http://linkedin.com/in/andreastagi Website: http://4spills.blogspot.it/ Github: http://github.com/astagi

—

Reply to this email directly or view it on GitHubhttps://github.com/openleap/PyLeapMouse/issues/3#issuecomment-13814816.

wyager commented 11 years ago

Alright, added instructions to the Readme about getting the proper library files. I really want to make this as easy as possible to get running, so I'm still going to leave the files there, but at least this way shouldn't be any more confusing than not having the files at all. At some point I'll add a conditional importer that discriminates based on the Python interpreter's bittiness. Or someone else can do it in the meantime and I'll merge it.

@schade Adding Linux support will be trivial; we'll just do it like it's done now (unless there's a cleaner-looking, more Pythonic way to do OS-Specific imports that I don't know about, of course).