Complete enough refactoring to build a sample school

openlearningtools / opencompetencies

A tool for organizing educational competencies.

MIT License

16 stars 3 forks source link

Complete enough refactoring to build a sample school #72

Closed ehmatthes closed 9 years ago

ehmatthes commented 9 years ago

[ ] Rename taxonomy.
- [ ] competencies -> graduation standards
[ ] Remove unused pages, views etc.

ehmatthes commented 9 years ago

competencies -> graduation standards

[x] CompetencyArea -> GraduationStandard
[x] competency_area -> graduation_standard
[x] competencyarea -> graduationstandard
- [ ] then search for comp

ehmatthes commented 9 years ago

essential understandings -> performance indicators

ehmatthes commented 9 years ago

learning targets -> learning objectives

ehmatthes commented 9 years ago

[x] python manage.py check
- [x] when this passes, migrate
- [x] this is a more complicated migration, so just rebuild the db for now?
- [ ] then further work
- [ ] then run tests
- blocking here
- [ ] then modify tests until they pass

ehmatthes commented 9 years ago

Current status: renamed elements in models.py, admin.py, views.py. Removed unused urls, view functions (1100 line views.py -> 600 line views.py), templates.

Tests won't run. Can create a school, but not a subject area. Main goals now:

[x] Make a subject area.
- Issue with auth, and circular migration issues? What worked - manage.py makemigrations competencies; manage.py migrate
[x] Get existing tests to run.

ehmatthes commented 9 years ago

Next focus: Build out some elements through performance indicator, make sure I can do it through site. Then consider tests, or building out a sample school. Tests, then really clean up views.py?

ehmatthes commented 9 years ago

Build out elements through PI - works, but not showing them. I can create them through edit_sa_summary, etc, but viewing on sa_summary doesn't show new GS or PI. They do show up in the admin, and in the shell. View code issues?

Issue was names like ca_eu, and for ca in ca_eus ca.competency_area.
- Needed to comb through view and template code.

ehmatthes commented 9 years ago

Next: focus on sa_summary and edit_sa_summary, make sure they work and display properly.

Write some tests!

How does a test ensure that a page is correct, not just status 200?
- Search for a phrase that should appear in the page's text?

ehmatthes commented 9 years ago

First test written that checks context. Checks that test_school appears in the context of the schools page.

ehmatthes commented 9 years ago

Closing this, as I'm currently writing tests. I'll open a separate issue for the actual refactoring.