openlegend / core-rules

Source text / code for Open Legend RPG
http://www.openlegendrpg.com/
Other
90 stars 56 forks source link

Ferocious minions #470

Closed BuildAndDie closed 7 years ago

BuildAndDie commented 7 years ago

Print edition and main github don't match

Main github needs updated to say Invoking Attribute 4/5/7 for the prerequisites.

jcte02 commented 7 years ago

Please see ufctool's review of the feats.yml file in PR #460. Invoking attribute is print only, in the site are listed the effective attributes.

Il 6 ott 2017 00:23, "Great Mustache Jonathan" notifications@github.com ha scritto:

Print edition and main github don't match

Main github needs updated to say Invoking Attribute 4/5/7 for the prerequisites.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openlegend/core-rules/issues/470, or mute the thread https://github.com/notifications/unsubscribe-auth/ABb1r7dbrPJEeBQgRQOhW5eO1UVZ17OPks5spVbhgaJpZM4Pvx_c .

jcte02 commented 7 years ago

Il 6 ott 2017 00:27, "Fabio Endrizzi" fabioendrizzibz@gmail.com ha scritto:

Please see ufctool's review of the feats.yml file in PR #460. Invoking attribute is print only, in the site are listed the effective attributes.

Il 6 ott 2017 00:23, "Great Mustache Jonathan" notifications@github.com ha scritto:

Print edition and main github don't match

Main github needs updated to say Invoking Attribute 4/5/7 for the prerequisites.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openlegend/core-rules/issues/470, or mute the thread https://github.com/notifications/unsubscribe-auth/ABb1r7dbrPJEeBQgRQOhW5eO1UVZ17OPks5spVbhgaJpZM4Pvx_c .

BuildAndDie commented 7 years ago

Where is this review, it isn't readily obvious to me going to #460

jcte02 commented 7 years ago

@BuildAndDie tldr: 1 2 3

BuildAndDie commented 7 years ago

Thanks for pointing me to this.

FYI

Energy and Alteration (as well as Creation and Entropy already listed) are for the Summon Boon, which Ferocious Minion benefits from. So in this case, it should include both of those.

jcte02 commented 7 years ago

@BuildAndDie I am a doofus. I confused Animation with Summon Creature (idk how) and this is why Logic is listed istead of Alteration and Energy. Gonna fix this one immediatly.

jcte02 commented 7 years ago

Fixed in #471. Thanks for the clarification in your last answer. If you wouldn't have pointed that out to me, I would have never spotted my mistake.

BuildAndDie commented 7 years ago

Personally, I like Logic being involved with it. And actually, technically, Logic makes sense to be in it.

When you animate a creature, it starts out with Charm on it, so in theory the attribute you used to do animate could also be what could trigger Ferocious Minions. Some might think that a stretch though I suppose.

But like I said, that could be a bit of a stretch. Glad to help, that's what I'm here for when I'm not being a headache to Brian!!! ;)