search

openlegend / core-rules

Source text / code for Open Legend RPG
http://www.openlegendrpg.com/
Other
90 stars 56 forks source link

Fixed epub missing chapter 9 header and TOC entry #490

Closed damccull closed 3 years ago

damccull commented 4 years ago

Chapter 8 needed a newline added at the end to allow for accurate rendering when outputting to epub. Otherwise the epub omits chapter 9's TOC entry and renders the chapter nine header in the book as text instead of a heading.

damccull commented 3 years ago

Any chance this will get merged?

BuildAndDie commented 3 years ago

Unfortunately no. The way the website was designed to work with this repository was a method that doesn't work anymore. There are a few other problems as well, making the handling of this repository not so straight forward.

There is another repository being worked on (with updated markdown language as well), which should be going live soon. At that time, errors and updates will be reviewed if still present in that repository. I'll keep an eye on this issue so it is hopefully not present there when it goes live.

damccull commented 3 years ago

@BuildAndDie Probably not the best place to put this, but can I suggest that instead of changing the repository entirely, if you have control over this one, just create a new branch, delete the current content, add your own new stuff, then merge back into master? That will replace the entirety of this repo's content with the new stuff, but still keep the history of it, as well as keeping this well known repository active as open legends official repo.

BuildAndDie commented 3 years ago

I understand the reasoning, but it is a bit more complicated than that due to the interaction with other things. There are a few other layers built in that aren't apparent at the public level. If this was just a straight repository and not anything else, I would do just that.

I'm defaulting to the suggestions of the person developing the web integration in the background. After things are confirmed to be working, this one will either be updated, or archived (as a just in case).