search

openlgtv / buildroot-nc4

Other
17 stars 9 forks source link

Upgrade moonlight-tv to 1.5.2 #8

Closed GuillaumeSmaha closed 2 years ago

GuillaumeSmaha commented 2 years ago

I am making a draft to show some advancement.

Enable host-nodejs to run moonlight-tv scripts during build. It is a required dependency: https://github.com/mariotaku/moonlight-tv/blob/v1.5.2/CMakeLists.txt#L107

@smx-smx Host-Python3 needs to be build with BR2_PACKAGE_HOST_PYTHON3_BZIP2=y. Do you know how this requirement can be defined in moonlight-tv package ? (Don't hesitate to update my PR or take my change for another PR/commit)

The build passes on my computer but remotely it is failing due to OOM:

I am trying with 17GB. That's weird that nodejs is taking so much memory.

GuillaumeSmaha commented 2 years ago

Finally works with 17GB. But It is flaky with 17GB because it fails on my cirrus pipeline: https://cirrus-ci.com/task/6233480374779904 Fails a second time on my cirrus: https://cirrus-ci.com/task/5893790203379712

GuillaumeSmaha commented 2 years ago

It seems building nodejs need a lot of memory

smx-smx commented 2 years ago

Let's see if this is sustainable. Thanks for the effort in tracking this down 👍

GuillaumeSmaha commented 2 years ago

No luck for the CI on master branch: Instance was rescheduled: https://cirrus-ci.com/task/6246328056414208

smx-smx commented 2 years ago

I think i will just get rid of moonlight-tv and host-nodejs in the lgtv default preset. It was used as a sample to see if there were all necessary components to build moonlight, but it's not really necessary as part of an SDK/toolchain and it's putting too much burden on the infrastructure.

GuillaumeSmaha commented 2 years ago

I think i will just get rid of moonlight-tv and host-nodejs in the lgtv default preset. It was used as a sample to see if there were all necessary components to build moonlight, but it's not really necessary as part of an SDK/toolchain and it's putting too much burden on the infrastructure.

Yes, good idea and it can still be recompiled by ourself if it is needed

smx-smx commented 2 years ago

Done