search

openlibhums / back_content

A plugin for Janeway used to load back content articles.
0 stars 2 forks source link

Back content plugin "Start Submission" button prompts server error #28

Closed joemull closed 2 years ago

joemull commented 2 years ago

Describe the bug In the back content plugin on Michigan's installation (but not my local one), selecting "Start Submission" prompts a server error.

Janeway version 1.4.0

To Reproduce Steps to reproduce the behavior:

  1. Go to https://journals.publishing.umich.edu/phimp/plugins/back_content
  2. Click on Start Submission
  3. See server error

Sentry flags this line: https://github.com/BirkbeckCTP/back_content/blob/d40ca3348a4b7e5b2e85db1163ca7464ffb574cf/forms.py#L87

It gives a TypeError: 'QuerySet' object is not callable

Each time you click Start Submission, the URL is incremented by one article ID, even though the error happens. This results in lots of empty started submissions.

joemull commented 2 years ago

Andy found a version mismatch between the plugin and the main repository that explained why this happened.