openlibhums / hourglass

Hourglass press theme for OLH
GNU Affero General Public License v3.0
1 stars 1 forks source link

Poor contrast ratio on red circles with black text #243

Open StephDriver opened 7 months ago

StephDriver commented 7 months ago

Report Issue

To Reproduce Steps to reproduce:

  1. Go to 'open access movement page'
  2. Scroll down to 1997. Then every alternate entry is themed in red, with black text on a red circle for the year heading.
  3. Contrast ratio of black on red is 4.24:1 which is a fail.

Screenshots

image

Preferred Solution

Instead of solid red and orange circles, have these as rings, with the background colour as an inner circle, such that the text is the same as the accompanying paragraph - nb this means updating the orange circles as well as the red ones.

e.g.

image
StephDriver commented 2 weeks ago

As an alternative to the solution above, how about this:

The black we use on the site (#202124), is not the darkest black there is, but neighbouring colours do affect the colour we see - so I think is is possible that if we change this black to #000000 just for the text within red circles, we'd then have appropriate contrast, and user's won't even notice it wasn't the same black as the paragraph nearby that is against a tan colour. Here's the example. I've only edited the colour of the text in the circle:

Image