search

openlibhums / hourglass

Hourglass press theme for OLH
GNU Affero General Public License v3.0
1 stars 1 forks source link

Copy to Clipboard button not working on supporters page. #406

Closed mauromsl closed 2 weeks ago

mauromsl commented 3 weeks ago

Describe the bug When using the Copy to Clipboard function on the recommend-us page, it doesn't do anything, other than change its text to "Copied"

To Reproduce Steps to reproduce the behavior:

  1. Go to recommend-us
  2. Complete the form for a new institution
  3. When the email text is presented, use the copy to clipboard function
  4. Inspect your clipboard or try to paste

Expected behavior Clipboard should be populated. In case of an error, it should be logged to console rather than swallowed.

Screenshots image

Desktop (please complete the following information): System A

StephDriver commented 2 weeks ago

confirmed as replicated on MacOS with Chrome. (ie. not copied to clipboard)

Also, once copied, the button turns to 'copied' and doesn't work a second time - this is not helpful A11y wise, it is important that someone can do the same action again if for some reason they've then been interrupted before pasting.

I suggest instead of copy -> copied have copy-> copy again

joemull commented 2 weeks ago

Confirmed with a discussion with Mauro and Steph that this was actually a mismatch between user expectation (that it pastes in places where plain text is supported, including a URL bar or a code editor), and design (that it pastes where html is supported, like an email editor window), as well as an apparent side effect on Arch Linux, where the clipboard manager does not recognize HTML copy events.

Proposed solutions