openlibhums / janeway

A web-based platform for publishing journals, preprints, conference proceedings, and books
https://janeway.systems/
GNU Affero General Public License v3.0
172 stars 65 forks source link

Captions and alt text display in material theme #2326

Closed joemull closed 1 year ago

joemull commented 3 years ago

Describe the bug Here are a few more article display issues to make you aware of related to the way captions and alt text display in the material theme:

Also attaching a screenshot of the inspection pane. XML is available for download from the article.

Janeway version 1.3.9

To Reproduce Steps to reproduce the behavior:

  1. Go to https://journals.publishing.umich.edu/gs/article/id/855/
  2. Scroll to figure 7.1.
  3. See alt text and lack of space before next p

Expected behavior A clear and concise description of what you expected to happen.

Screenshots Screen Shot 2021-07-13 at 1 02 59 PM

pgoussy commented 1 year ago

Bumping this up because I just encountered some articles w/ image alt-text, and the text tagged with <alt-text> (seemingly correct per JATS spec) is still visually displaying in the HTML: https://journals.publishing.umich.edu/gs/plugins/typesetting/preview_galley/article/2489/galley/1732/

pgoussy commented 1 year ago

Bumping this up yet again to point out that evidently it is not limited to the Material theme. The alt-text displays visibly with OLH as well--and unlike Material, the styling and alignment of the displayed alt-text appears identical to regular paragraph text, without any indication that it's part of the preceding figure/caption.

https://journals.publishing.umich.edu/ars/plugins/typesetting/preview_galley/article/3986/galley/2032/

2023-03-29_16-17-03

ajrbyers commented 1 year ago

@pgoussy I’ll speak to the team tomorrow about adding a fix to liquid XSL for this. Permafix is in for the 1.5.1 release.

pgoussy commented 1 year ago

@ajrbyers Do you think a hotfix for this is feasible? Or will we need to wait until 1.5.1?

mauromsl commented 1 year ago

@ajrbyers Do you think a hotfix for this is feasible? Or will we need to wait until 1.5.1?

Now that you have the Liquid XSLT plugin, it should be fine to add this to your install as soon as it is ready. I'm on the case