openlibhums / janeway

A web-based platform for publishing journals, preprints, conference proceedings, and books
https://janeway.systems/
GNU Affero General Public License v3.0
168 stars 63 forks source link

Janeway not supporting "continued-from" attribute on ordered lists #2650

Closed pgoussy closed 2 years ago

pgoussy commented 2 years ago

Describe the bug Our XML vendor has used the continued-from attribute for ordered lists that are interrupted with non-list content. Though they seem to be correctly following the JATS spec, Janeway is incorrectly treating the "continued" list as a brand new ordered list (i.e., starting over at 1 rather than continuing the numbering from the original list as expected).

To Reproduce Steps to reproduce the behavior:

  1. Go to https://journals.publishing.umich.edu/ergo/plugins/typesetting/preview_galley/article/1136/galley/435/
  2. Scroll down to Introduction
  3. Notice list items 1, 2, 3, then a line of plain text, then another list item 1. This second "1" should instead be a "4" to continue the first list's numbering scheme.
<p id="P2">Leibniz argues against the Cartesian conception of material substance, that is, the view that matter consists in extension alone, based on considerations of unity. Leibniz&#x2019;s Argument from Unity, as I will call it, can be rendered as follows:
<list list-type="order" id="L1">
<list-item><p id="P3">Matter (i.e., extension alone) is a plurality of parts to infinity.</p></list-item>
<list-item><p id="P4">A plurality of parts cannot be a true unity.</p></list-item>
<list-item><p id="P5">A substance must be a true unity.</p>
</list-item>
</list></p>
<p id="P6">Therefore,
<list list-type="order" id="L2" continued-from="L1">
<list-item><p id="P7">Matter (i.e., extension alone) is not a substance.<sup><xref rid="FN1" ref-type="fn">1</xref></sup></p></list-item>
</list></p>

Expected behavior https://jats.nlm.nih.gov/publishing/tag-library/1.3/attribute/continued-from.html

pgoussy commented 2 years ago

Bumping this up as an issue that we've had a few authors commenting on during their proofread of the JATS. Would this be a good test candidate for the liquid XSLT? Or will we need to wait for 1.4.2?