openlibhums / janeway

A web-based platform for publishing journals, preprints, conference proceedings, and books
https://janeway.systems/
GNU Affero General Public License v3.0
172 stars 65 forks source link

Update mobile template to add max width for logo/header image #2729

Open lstachew opened 2 years ago

lstachew commented 2 years ago

Is your feature request related to a problem? Please describe. Weave noticed that on mobile, their logo/header image overlaps with the hamburger icon at the top (see screenshot-logo-overlap). We found that if we made the logo taller by adding more white space on the top and bottom of the image (essentially making the logo less wide, proportionally) this solved the issue on mobile (see screenshot-mobile-view-new), however, as a result, on the desktop view, the logo became much smaller (see screenshot-weave-desktop).

Describe the solution you'd like Update the mobile template so that there is a maximum width to the logo/header image. Since we found that making the logo taller fixed the issue on mobile, it seems that a lack of width constraint is what is causing wider logos to run into the hamburger icon.

Screenshots: screenshot-logo-overlap

screenshot-mobile-view-new

screenshot-weave-desktop

joemull commented 2 years ago

What we might fix in tandem with this is the persistent issue where the navigation items run into the journal logo.

Screenshot from 2022-05-26 16-34-55

This might be possible by moving the items closer together if they start to overlap the logo.

This is only an issue for navigation bars with lots of items, and only at a certain width before the webpage switches to the small screen layout with the collapsed navigation menu.

StephDriver commented 7 months ago

What we might fix in tandem with this is the persistent issue where the navigation items run into the journal logo.

Screenshot from 2022-05-26 16-34-55

This might be possible by moving the items closer together if they start to overlap the logo.

This is only an issue for navigation bars with lots of items, and only at a certain width before the webpage switches to the small screen layout with the collapsed navigation menu.

more info at #4052