search

openlibhums / janeway

A web-based platform for publishing journals, preprints, conference proceedings, and books
https://janeway.systems/
GNU Affero General Public License v3.0
172 stars 65 forks source link

Email Subjects on Template #3043

Closed ajrbyers closed 2 years ago

ajrbyers commented 2 years ago

Describe the bug Currently the email subject value displayed is hard coded on the template.

Janeway version 1.4.1

Expected behavior The email subject for the template being sent should be displayed.

Additional We should check that all email subjects conform to the pattern: subject_name_of_related_template this can be achieved by a test and will also identify any that do not conform.

ajrbyers commented 2 years ago
ajrbyers commented 2 years ago

See PRs on Typesetting and APC:

joemull commented 2 years ago

@ajrbyers In addition to the PRs on apc and typesetting, does the fix for this involve https://github.com/BirkbeckCTP/janeway/compare/3043-email_subjects ? Ready for a PR?

ajrbyers commented 2 years ago

Mmm we agreed this wouldn’t go forward as @mauromsl was making changes to these templates.

joemull commented 2 years ago

Mmm we agreed this wouldn’t go forward as @mauromsl was making changes to these templates.

OK, then is there anything that I can do on this issue @ajrbyers @mauromsl ? I set the status to in progress.

ajrbyers commented 2 years ago

See this PR: https://github.com/BirkbeckCTP/janeway/pull/3121