openlibhums / janeway

A web-based platform for publishing journals, preprints, conference proceedings, and books
https://janeway.systems/
GNU Affero General Public License v3.0
168 stars 63 forks source link

Plugins cannot be updated when Janeway is updated to a new version of Django #3462

Closed mauromsl closed 1 year ago

mauromsl commented 1 year ago

Describe the bug When plugin upgrades introduce a breaking change that also depends on a change to a new version of django, it can be very difficult to upgrade them

Janeway version v1.4.4

To Reproduce If you upgrade your Janeway installation so that it uses a new version of Django introducing breaking changes, it is likely that you will need to also update your plugins. At that point Janeaway will be set to a new version x.y.z and the updated plugin will pin that version as their JANEWAY_VERSION. When running the update.sh script with these two updated codebases, Janeway will fail to load any management commands because the version the plugin requires (x.y.z) has not yet been installed. If you update Janeway's codebase first but not the plugin, errors might be raised due to the plugin not being updated

Expected behavior The new Janeway version against which the plugin version is checked, needs to be checked against the codebase, rather than against the value stored in the database.

mauromsl commented 1 year ago

Closed by #3515