search

openlibhums / janeway

A web-based platform for publishing journals, preprints, conference proceedings, and books
https://janeway.systems/
GNU Affero General Public License v3.0
168 stars 63 forks source link

Text following <disp-quote> within same <p> is not styled correctly #3631

Open pgoussy opened 1 year ago

pgoussy commented 1 year ago

Describe the bug If a <disp-quote> is tagged within a <p>, any text within the same <p> that appears after the block quote does not follow the same text styling as standard <p> text. Any text in the same <p> before the block quote is styled normally.

Janeway version 1.4.3

To Reproduce Steps to reproduce the behavior:

  1. Go to https://journals.publishing.umich.edu/mij/plugins/typesetting/preview_galley/article/2357/galley/2473/
  2. Click on "Supportive of Crunch Themes" in the TOC
  3. Scroll down to '"Good" Crunch' subsection heading
  4. See that all text following the block quote is styled differently from text preceding it. All of this subsection, including the <disp-quote, is contained within a single <p>

Screenshots image

Desktop (please complete the following information): Windows 11, Chrome v. 114.0.5735.199 (64-bit)

pgoussy commented 1 year ago

Bumping this up as I've just realized the same styling error occurs when a <list> appears in the middle of a <p> with plain text on either side. (i.e., the text after the <list> within the same <p> is not spaced correctly)

image

I'm kind of shocked that neither I nor reviewing authors ever noticed this before. Is this a newly-introduced bug in 1.5.0?

pgoussy commented 11 months ago

Bumping this up again to note that the same styling error occurs when <disp-formula> appears in the middle of a <p> as well.

image

pgoussy commented 4 months ago

Bumping this up once again to note that the same styling error also occurs when <verse-group> appears in the middle of a <p> with text on either side.