Document manager file upload error

[everreau]

Describe the bug When a user attempts to upload a file but clicks an upload button that does not correspond to the document field it causes a server error

Janeway version 1.5.0

To Reproduce

1. Go to document management for any article
2. Click "Upload File"
3. Fill in file label
4. Select a document under "New Manuscript File"
5. Click the "Upload" button in the "Figure/Data File" section

Expected behavior Probably this should cause a form error indicating there is no file to upload but also the interface could be changed so there aren't a bunch of different upload buttons.

Front-end Issues

If the issue is front-end specific please add the following details:

Desktop (please complete the following information):

• MacOS 13.2.1
• Firefox 118.0.1

[StephDriver]

Investigated, and this particular bug squashed, but then failed tests, which when compared to original, were also failed by master branch.

-The manuscript and data files upload fine. -The production files upload as manuscript. -The proofing files appear to cause an infinite loop of uploads, requiring test server to be halted.

these must be addressed before this issue can be resolved.

[StephDriver]

proposed bugfix:

Instead of a single upload button leading to a popup with multiple file upload options, multiple file upload buttons leading to a popup for uploading that specific file type:

so from this:

to this:

with similar popups for each of the other file types.

[StephDriver]

Initial solution to be replaced as per reviewer comment on #3847

Thanks for this StephDriver. Rather than having 4 buttons and 4 modals could we instead have a single button and a single popup and use a drop down for the file type on the form?

[StephDriver]

Restarting this work so that it is a form as per reviewer on #4292 :

Sorry, Steph, you're going to hate me... but... we should probably have this as a Django form to reduce some of the view logic.