search

openlibhums / janeway

A web-based platform for publishing journals, preprints, conference proceedings, and books
https://janeway.systems/
GNU Affero General Public License v3.0
168 stars 63 forks source link

Exporting all articles - metadata field issue #4109

Closed S-Haime closed 1 month ago

S-Haime commented 4 months ago

Describe the bug There is an issue with the metadata fields, where a field has been deleted but the answer is still stored. This causes an error when trying to do an export, making it impossible to export metadata. If the answer was stored so that it contains the question itself, rather than the linked object this might resolve the issue. Additionally, this shouldn't be killing the export even if an answer is not found.

Janeway version The version of Janeway under which the bug has been reproduced. If running off of master, please, indicate the current HEAD of the Janeway installation

To Reproduce Steps to reproduce the behavior:

  1. https://jcls.io/plugins/imports/articles/all/
  2. Export all or Export CSV.

Additional context Reported by jcls (ULB) FD 8101

joemull commented 1 month ago

Backlog refinement: We can do a quick-fix by adding a try / except check around the code that gets custom fields.

Longer term we might want to make sure answers are deleted when the question is deleted. Maybe, maybe not. What does it mean to delete a submission field? Need to discuss further.

joemull commented 1 month ago

@S-Haime could we copy and paste this over to BirkbeckCTP/imports?

S-Haime commented 1 month ago

@joemull Done. Also added to 'need investigation', can I close this issue?

joemull commented 1 month ago

@S-Haime Yep, thanks