search

openlibhums / janeway

A web-based platform for publishing journals, preprints, conference proceedings, and books
https://janeway.systems/
GNU Affero General Public License v3.0
176 stars 65 forks source link

Standardize spelling of licence / license #4224

Open joemull opened 5 months ago

joemull commented 5 months ago

Some downstream code expects the British spelling "licence":

https://github.com/BirkbeckCTP/janeway/blob/5ff3d233223eb61328755ae99b9f45e81735bc13/src/templates/common/elements/article_meta_tags.html#L24

But the models use the US spelling "license":

https://github.com/BirkbeckCTP/janeway/blob/5ff3d233223eb61328755ae99b9f45e81735bc13/src/submission/models.py#L642

https://github.com/BirkbeckCTP/janeway/blob/5ff3d233223eb61328755ae99b9f45e81735bc13/src/repository/models.py#L428

Except when they don't:

https://github.com/BirkbeckCTP/janeway/blob/5ff3d233223eb61328755ae99b9f45e81735bc13/src/submission/models.py#L2160

joemull commented 3 weeks ago

Discussion from refinement: In code we are usually constrained to US spelling, so we think we should standardize this to US spelling for consistency.