openlibhums / janeway

A web-based platform for publishing journals, preprints, conference proceedings, and books
https://janeway.systems/
GNU Affero General Public License v3.0
172 stars 65 forks source link

Revise article internal cross references #4245

Open StephDriver opened 4 months ago

StephDriver commented 4 months ago

Background

Cross referencing, and returning back to the original position having followed up on a cross reference are important for the readability of articles. This needs to work better. Our current situation is outlined below:

Currently

Task

StephDriver commented 4 months ago

Examples from #4194

StephDriver commented 3 months ago

Note that the ^ is too small to be a link, the minimum size is given by WCAG 2.5.8 as 24 px by 24 px.

It is only 6.5px by 20.8px.

StephDriver commented 3 months ago

Dynamic page breadcrumb is for future discussion.

@StephDriver Split this into individual issues for more immediate work.

StephDriver commented 2 days ago

Revising and defining the work required on this issue

handled elsewhere

cross references to other sections (e.g. a 'see section 4') are not consistently marked up as internal links, even within the same article, some will be marked as links, some will be plain text.

  • This is a matter of user content - added to placeholder for Phase 2 issues #4085

The indices used to indicate an endnote are not contextual links

  • indices for endnotes should be connected to their destination anchor by aria-labelledby to give them context - the same approach as is being used for citation links in #3939 so I have added this to that issue.

to do here

Material theme does allow for return from endnote to original position, but does not have contextual links for this, with all such links being 'carat' ^ which is also too small a target for accessible selection.

for figures, there is no distinction made between the cross-reference link to the figure, and the link which enlarges the figure.

  • [ ] update 'enlarge figure' links to state exactly that - that they enlarge the figure. An aria-label could be used here, but I'd prefer the link itself to be visually obvious as to its purpose.
joemull commented 12 hours ago

@StephDriver to create a separate issue for the carat, to investigate what others are doing and design the content and appearance of the back reference button.

This issue is now just about the other button for enlarging figures.

StephDriver commented 7 hours ago

style the carat to make it meet WCAG 2.5.8

and

@StephDriver to create a separate issue for the carat, to investigate what others are doing and design the content and appearance of the back reference button.

this is now set as: