openlibhums / janeway

A web-based platform for publishing journals, preprints, conference proceedings, and books
https://janeway.systems/
GNU Affero General Public License v3.0
174 stars 65 forks source link

External links in nav dont open in a new tab #4287

Open S-Haime opened 4 months ago

S-Haime commented 4 months ago

Describe the bug Despite a link being marked as external and going to an external website, the page does not open in a new tab.

Janeway version 1.5.2.

To Reproduce https://www.jscdm.org/ Under 'Glossaries' in the navbar -> MRCT glossary -> does not open in new tab

Expected behavior external links to open in new tab.

the-blochian commented 2 months ago

This is a really annoying part of OLH journals' nav bars. Several of the drop-down menu options (like Publisher Policies, OA Policies, Ethics & Malpractice) take you to the OLH website. These really need to open in a new tab, otherwise users are taken away from the journal website and get lost, then having to scroll back to find it again.

StephDriver commented 5 days ago

We should also clearly mark them as opening in an external tab for A11y (thinking of the drop downs, not the original post which does have them marked).

ajrbyers commented 5 days ago

From backlog refinement: