search

openlibhums / janeway

A web-based platform for publishing journals, preprints, conference proceedings, and books
https://janeway.systems/
GNU Affero General Public License v3.0
177 stars 65 forks source link

Make Front of House Icons Accessible #4215 #4492

Open StephDriver opened 1 week ago

StephDriver commented 1 week ago

closes #4215

StephDriver commented 23 hours ago

Note, while an aria-label on an <a> should mean that everything inside, including any icons, are then hidden as the label takes precedence, SiteImprove has been flagging up internal elements as not being accessible despite this... so in a belt and braces approach I have marked internal icons as hidden regardless of aria label.

StephDriver commented 22 hours ago

I have set this up so that there are comments in the code explaining the updates, which I then removed before testing. So to see the reason behind a change, please look at what those comments were (removed in commit be729f2)

StephDriver commented 21 hours ago

Work remaining: