search

openlibhums / janeway

A web-based platform for publishing journals, preprints, conference proceedings, and books
https://janeway.systems/
GNU Affero General Public License v3.0
177 stars 65 forks source link

Minor inconsistent error handling in choosing a proof-reader/Assignment of proofreader fails (?) #655

Closed ccaadeh closed 5 years ago

ccaadeh commented 5 years ago

Logged in with a privileged account. 1) I assign a proofreader using someone with the designated role. But don't enter any proofreading instructions nor a date and click on 'Add proofreader'. I get warned that I must pick a date so I do, and click on 'Add proofreader', again, but still nothing happens.

screenshot 35 I must enter some text in order to be able to complete the task, but no warning about this is given.

2) https://demojournal.janeway.systems/proofing/ I want to assign proofing manager (which mistankenly (?) shows up as production manager)

'deh292 none' (why does it say 'none?) screenshot 36 screenshot 37

I choose dhe292 and a message box pops telling me that deh292 has been assigned as Proofreader. screenshot 39 So the task appears to be in hand

screenshot 39

Yet nothing appears to have been assigned either viewing as a privilged account: screenshot 38

Nor when viewed by deh292 account as showing a task to be performed: screenshot 40

ajrbyers commented 5 years ago

This is two clearly separate issues in one. The second, however, isn’t a bug. The proofing manager is not a proofreader but the person who manages the proofing process and assigned the proofreaders. To test you should assign yourself as the manager THEN assign proofreaders.

ccaadeh commented 5 years ago

Andy, would like me to close this one, and open a new one having removed the second part? David

On Fri, Nov 23, 2018 at 12:56 PM Andy Byers notifications@github.com wrote:

This is two clearly separate issues in one. The second, however, isn’t a bug. The proofing manager is not a proofreader but the person who manages the proofing process and assigned the proofreaders. To test you should assign yourself as the manager THEN assign proofreaders.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BirkbeckCTP/janeway/issues/655#issuecomment-441234738, or mute the thread https://github.com/notifications/unsubscribe-auth/AqYmRc_VVf1qyaE1ih8GqiEdnWhT_78Xks5ux_CJgaJpZM4YwmNA .

ajrbyers commented 5 years ago

@ccaadeh yes please.