openlibhums / pandoc_plugin

Plugin for janeway for automatic galley generation
GNU Affero General Public License v3.0
4 stars 1 forks source link

graceful error message if pandoc fails #3

Closed mdlincoln closed 5 years ago

mdlincoln commented 5 years ago

If pandoc chokes on the file it tries to convert, it should display a meaningful message in the management interface. Right now, it always assumes that pandoc will work, and so sends the user to a non-existent URL if no file was successfully converted.

mdlincoln commented 5 years ago

@ajrbyers how does Janeway like to display errors that need to be seen by humans in the management interface?

ajrbyers commented 5 years ago

We use the Messages framework:

https://docs.djangoproject.com/en/1.11/ref/contrib/messages/

These errors then appear as Toasts with different colours dependent on the message level.

mdlincoln commented 5 years ago

This was closed by #8