search

openlibraryenvironment / reshare-analytics

Community query repository for ReShare analytics based on Metadb/LDP
Apache License 2.0
3 stars 2 forks source link

updates to remaining report README files #34

Closed julienye closed 2 years ago

julienye commented 2 years ago

This pull request includes updates to two reports not previously reviewed: supplying turnaround and requesting ratio.

I think it also includes previously-reviewed requesting turnaround and overdues reports.

julienye commented 2 years ago

Kristen, the review request included several files, and I'm not sure which this comment refers to. I'll send you links to each of my 'final' drafts via slack. hopefully that will make it easier for you to see each file...

On Fri, Jan 7, 2022 at 11:35 AM Kristen Wilson @.***> wrote:

@.**** requested changes on this pull request.

Julie, I'm not sure I'm looking at the right version of this, so apologies if you've done this and I'm just not seeing it. For the definition, it seems like should clarify the difference between the average and median times, as well as the counts (requests under 48, etc.).

— Reply to this email directly, view it on GitHub https://github.com/openlibraryenvironment/reshare-analytics/pull/34#pullrequestreview-846782791, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVUFOPGQY4Y776JE2OQXPM3UU4I6XANCNFSM5LLC3DJQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.*** com>

nassibnassar commented 2 years ago

@kristenwilson @julienye If it helps, you can click on the "Files changed" tab, and then click on a plus sign ( + ) on the left to select a line (or select multiple lines) in order to leave a comment on a specific file.

julienye commented 2 years ago

oh, wow - that's good to know, thanks, Nassib!

On Mon, Jan 10, 2022 at 10:49 AM Nassib Nassar @.***> wrote:

@kristenwilson https://github.com/kristenwilson @julienye https://github.com/julienye If it helps, you can click on the "Files changed" tab, and then click on a plus sign ( + ) on the left to select a line (or select multiple lines) in order to leave a comment on a specific file.

— Reply to this email directly, view it on GitHub https://github.com/openlibraryenvironment/reshare-analytics/pull/34#issuecomment-1009013676, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVUFOPCJFDYWZM7ULSNE3DDUVL5ZPANCNFSM5LLC3DJQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

julienye commented 2 years ago

@kristenwilson - there is still a question you haven't responded to, in the supplying_turnaround README. I also just asked you the same question in Slack. if you reply, I'll remove it from the README file and you can approve the changes and it will all be ready for NN to merge. Thanks!