search

openlilylib / LO-ly

LibreOffice-LilyPond extension
13 stars 6 forks source link

Added function GetRelativeIncludeStatement #25

Closed edgar79 closed 5 years ago

edgar79 commented 5 years ago

Hello,

I wrote this patch to automatically include the path to the LibreOffice-File. Using this it would be easy to share external LilyPond-Files with the LibreOffice-File without setting the include option manually for every file.

Mit freundlichen Grüßen und vielem Dank, Hannes E. Schäuble

KlausBlum commented 5 years ago

Hello,

thank you very much for your contribution. This is indeed a great idea, and I'd like to integrate your code into the next release.

One remark: I'd like to change the order of the statements to sIncludeStatement = sRelativeIncludeStatement & " " & sIncludeStatement

With that, sRelativeIncludeStatement has priority over the other paths. That means, even if I have an include file with the same name in my default folder, LO will use the one from the document folder.

What do you think?

Herzliche Grüße, Klaus Blum

edgar79 commented 5 years ago

Hello,

your proposed change to increase the priority of the sRelativeIncludeStatement is a good idea too, so I just pushed it into this branch.

Herzliche Grüße, Hannes Schäuble

KlausBlum commented 5 years ago

Hi Hannes,

that's a really cool and useful enhancement. Thanks again. I'll merge your branch into master.

Cheers, Klaus

KlausBlum commented 5 years ago

Integrated into 0.5.9 Release: https://github.com/openlilylib/LO-ly/releases/tag/0.5.9