search

openlilylib / lilypond-export

LilyPond export API to write Humdrum, MusicXML and more
GNU General Public License v3.0
22 stars 8 forks source link

Few tweaks #20

Closed rshura closed 5 years ago

rshura commented 5 years ago
rshura commented 5 years ago

I remember @jpvoigt saying that dynamics we're one moment late in MuseScore, so I think it should be easy for him to check.

jpvoigt commented 5 years ago

OK I haven't had the chance to deeply look into this, but it looks harmless ;-) so merged it to test it

jpvoigt commented 5 years ago

OK I test with the 3 example-files. Now the dynamics are in place. In example2 the Hairpin seems to be a little problem: MuseScore says something about "wedge" not in the right position and it doesn't end at the piano, but that is not a static Dynamic event, so it is another issue ;-)

Am 07.11.18 um 18:28 schrieb Alex Roitman:

I remember @jpvoigt https://github.com/jpvoigt saying that dynamics we're one moment late in MuseScore, so I think it should be easy for him to check.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openlilylib/lilypond-export/pull/20#issuecomment-436707786, or mute the thread https://github.com/notifications/unsubscribe-auth/ADFWTo7bd6Ls6iEpCQuFirJE8kVDag-Yks5usxhKgaJpZM4YPxpT.

rshura commented 5 years ago

Hmm, I moved both absolute- and span- dynamics in front of the note, since they both seemed late before. Now they look correct in Finale.

Now that I look at example 2, I guess one thing I didn't do, and that has nothing to do with "before-or-after-the-note" question, is the failure to terminate hairpins on absolute dynamic event. In example 2, there's crescendo follow by a \f rather than ! Since I'm parsing events in this case, I think I never get the end event.

I'll check this tonight, maybe even fix it if my guess is correct. I my guess is correct, you should see the same hairpin issue with example2 even without my latest change :-)

Thanks, Alex

On Wed, Nov 7, 2018 at 9:36 AM jpvoigt notifications@github.com wrote:

OK I test with the 3 example-files. Now the dynamics are in place. In example2 the Hairpin seems to be a little problem: MuseScore says something about "wedge" not in the right position and it doesn't end at the piano, but that is not a static Dynamic event, so it is another issue ;-)

Am 07.11.18 um 18:28 schrieb Alex Roitman:

I remember @jpvoigt https://github.com/jpvoigt saying that dynamics we're one moment late in MuseScore, so I think it should be easy for him to check.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/openlilylib/lilypond-export/pull/20#issuecomment-436707786 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ADFWTo7bd6Ls6iEpCQuFirJE8kVDag-Yks5usxhKgaJpZM4YPxpT .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openlilylib/lilypond-export/pull/20#issuecomment-436710467, or mute the thread https://github.com/notifications/unsubscribe-auth/AI_Aah98DHtewZRYGuhZIzQTjcgm0Jq5ks5usxoigaJpZM4YPxpT .

jpvoigt commented 5 years ago

That sounds reasonable. I guess you are right.

Am 07.11.18 um 18:49 schrieb Alex Roitman:

Hmm, I moved both absolute- and span- dynamics in front of the note, since they both seemed late before. Now they look correct in Finale.

Now that I look at example 2, I guess one thing I didn't do, and that has nothing to do with "before-or-after-the-note" question, is the failure to terminate hairpins on absolute dynamic event. In example 2, there's crescendo follow by a \f rather than ! Since I'm parsing events in this case, I think I never get the end event.

I'll check this tonight, maybe even fix it if my guess is correct. I my guess is correct, you should see the same hairpin issue with example2 even without my latest change :-)

Thanks, Alex

On Wed, Nov 7, 2018 at 9:36 AM jpvoigt notifications@github.com wrote:

OK I test with the 3 example-files. Now the dynamics are in place. In example2 the Hairpin seems to be a little problem: MuseScore says something about "wedge" not in the right position and it doesn't end at the piano, but that is not a static Dynamic event, so it is another issue ;-)

Am 07.11.18 um 18:28 schrieb Alex Roitman:

I remember @jpvoigt https://github.com/jpvoigt saying that dynamics we're one moment late in MuseScore, so I think it should be easy for him to check.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <

https://github.com/openlilylib/lilypond-export/pull/20#issuecomment-436707786

, or mute the thread <

https://github.com/notifications/unsubscribe-auth/ADFWTo7bd6Ls6iEpCQuFirJE8kVDag-Yks5usxhKgaJpZM4YPxpT

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub

https://github.com/openlilylib/lilypond-export/pull/20#issuecomment-436710467, or mute the thread

https://github.com/notifications/unsubscribe-auth/AI_Aah98DHtewZRYGuhZIzQTjcgm0Jq5ks5usxoigaJpZM4YPxpT .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openlilylib/lilypond-export/pull/20#issuecomment-436714682, or mute the thread https://github.com/notifications/unsubscribe-auth/ADFWTqELXmAxiF8KUfO5hFSUsBfkfkmwks5usx0SgaJpZM4YPxpT.