search

openlilylib / lilypond-export

LilyPond export API to write Humdrum, MusicXML and more
GNU General Public License v3.0
22 stars 8 forks source link

Make absolute dynamics also be the stop for the span dynamics. #21

Closed rshura closed 5 years ago

rshura commented 5 years ago

This should fix the export-example2.ly -- @jpvoigt let me know if there's any more issues with that file,

jpvoigt commented 5 years ago

Great! The Hairpin stops as expected. MuseScore still complains about bad placement of the wedge element (only in example2), but it loads correctly.

rshura commented 5 years ago

Can you tell me more? What exactly is the problem with that XML?

On Wed, Nov 7, 2018 at 10:42 PM jpvoigt notifications@github.com wrote:

Great! The Hairpin stops as expected. MuseScore still complains about bad placement of the wedge element (only in example2), but it loads correctly.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openlilylib/lilypond-export/pull/21#issuecomment-436889788, or mute the thread https://github.com/notifications/unsubscribe-auth/AI_AajZYsX4-skW_xFGVCH-wCSDFIxOFks5us9I_gaJpZM4YT9hB .

jpvoigt commented 5 years ago

I can't tell you how it would be right, perhaps it is only a problem with MuseScore, but still if you drop the file into http://verovio.humdrum.org/ the hairpin is missing.

Where is the wedge to be placed according to the specs?

Am 08.11.18 um 07:44 schrieb Alex Roitman:

Can you tell me more? What exactly is the problem with that XML?

On Wed, Nov 7, 2018 at 10:42 PM jpvoigt notifications@github.com wrote:

Great! The Hairpin stops as expected. MuseScore still complains about bad placement of the wedge element (only in example2), but it loads correctly.

rshura commented 5 years ago

The MusicXML docs show examples with wedge being under direction->direction-type element: https://usermanuals.musicxml.com/MusicXML/Content/EL-MusicXML-wedge.htm

I think that's what I got. I don't know if the absolute dynamics should be before or after the wedge. Maybe you can try changing that order and see if it helps?

On Wed, Nov 7, 2018 at 10:57 PM jpvoigt notifications@github.com wrote:

I can't tell you how it would be right, perhaps it is only a problem with MuseScore, but still if you drop the file into http://verovio.humdrum.org/ the hairpin is missing.

Where is the wedge to be placed according to the specs?

Am 08.11.18 um 07:44 schrieb Alex Roitman:

Can you tell me more? What exactly is the problem with that XML?

On Wed, Nov 7, 2018 at 10:42 PM jpvoigt notifications@github.com wrote:

Great! The Hairpin stops as expected. MuseScore still complains about bad placement of the wedge element (only in example2), but it loads correctly.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openlilylib/lilypond-export/pull/21#issuecomment-436892456, or mute the thread https://github.com/notifications/unsubscribe-auth/AI_Aajktb4w6S3v98lk3LhtVe6Iy1f8Dks5us9XCgaJpZM4YT9hB .

jpvoigt commented 5 years ago

Now I got it: wedge and dynamics both need there own direction-type element:

Am 08.11.18 um 08:55 schrieb Alex Roitman:

The MusicXML docs show examples with wedge being under direction->direction-type element: https://usermanuals.musicxml.com/MusicXML/Content/EL-MusicXML-wedge.htm

I think that's what I got. I don't know if the absolute dynamics should be before or after the wedge. Maybe you can try changing that order and see if it helps?

On Wed, Nov 7, 2018 at 10:57 PM jpvoigt notifications@github.com wrote:

I can't tell you how it would be right, perhaps it is only a problem with MuseScore, but still if you drop the file into http://verovio.humdrum.org/ the hairpin is missing.

Where is the wedge to be placed according to the specs?

Am 08.11.18 um 07:44 schrieb Alex Roitman:

Can you tell me more? What exactly is the problem with that XML?

On Wed, Nov 7, 2018 at 10:42 PM jpvoigt notifications@github.com wrote:

Great! The Hairpin stops as expected. MuseScore still complains about bad placement of the wedge element (only in example2), but it loads correctly.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub

https://github.com/openlilylib/lilypond-export/pull/21#issuecomment-436892456, or mute the thread

https://github.com/notifications/unsubscribe-auth/AI_Aajktb4w6S3v98lk3LhtVe6Iy1f8Dks5us9XCgaJpZM4YT9hB .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/openlilylib/lilypond-export/pull/21#issuecomment-436904448, or mute the thread https://github.com/notifications/unsubscribe-auth/ADFWTleFMjQ-OKTeAR8PgN0EL-lC3eVZks5us-NggaJpZM4YT9hB.

rshura commented 5 years ago

Great, did that and pushed directly to MusicXML-dev, it was a tiny change.