search

openlilylib / snippets

A place to store useful pieces of LilyPond code - custom functions, engravers, hacks, templates, examples etc.
Other
120 stars 38 forks source link

test: Check lilypond version of test files #112

Closed Cecca closed 9 years ago

Cecca commented 9 years ago

Using the method is_runnable_file the automated_tests.py script now excludes test files requiring a LilyPond version with version number greater than the one currently in use.

The method was already present and used in the first versions of the script, it appears that its invocation was lost during the restructuring of the test script.

Cecca commented 9 years ago

For lilypond 2.18.2 non runnable test files are correctly skipped: see here.

For lilypond 2.19.2 there seems to be syntax errors in ly/stylesheets/usage-examples/arnold--berg-opus-5-excerpt.ly, but that is unrelated to this PR.

This should fix #111.

uliska commented 9 years ago

Thank you, I'll see when I have the time to look into it.

For lilypond 2.19.2 there seems to be syntax errors in ly/stylesheets/usage-examples/arnold--berg-opus-5-excerpt.ly, but that is unrelated to this PR.

These errors are due to the fact that the Arnold font has not been released yet so it can't be downloaded. So yes, these are unrelated.

But IISC this only solves half of the issue in #111, namely the part with incompatible versions. The strange caching inconsistency isn't touched by it.

Cecca commented 9 years ago

Yes, it doesn't touch the caching issue, I have no time to look into that right now. Anyway this PR is meant only to deal with version checks, so in my opinion it can be merged

uliska commented 9 years ago

OK. Looking at the Travis logs (don't have a Lily computer right now) it looks fine. Some issues remain because you haven't some commits from my unmerged branch, so they don't matter.