search

openlilylib / snippets

A place to store useful pieces of LilyPond code - custom functions, engravers, hacks, templates, examples etc.
Other
120 stars 38 forks source link

make lyric-syllable-magnetic-snap work with recent versions #128

Open akobel opened 9 years ago

uliska commented 9 years ago

Just looking at the commit through the web interface, and I have a question: Will the changed code work with only new LilyPonds (if so, starting with which version exactly?) or with older and newer versions?

If this is a breaking change it might be a good idea to wrap it with the lilypond-version-predicates. And it should be documented.

akobel commented 9 years ago

Indeed, good point. At least it does not work anymore with v2.18.2. I need to check which change was responsible for the different behaviour. As a reminder to myself: an educated guess after git grep grob-propert is something around 2.19.10 or 2.19.11, but I have yet to confirm this.

BTW, this fix only makes Lilypond to accept the input; it does not (aim to) make the entire approach work. Just saying, because it doesn't work, or at least not reliably.

uliska commented 9 years ago

BTW, the Success messages of the Continuous Integration server don't say anything because they really only test the units in the new structure that do have "unit tests".

uliska commented 8 years ago

@akobel could you have a look into this if it is still relevant, needs more work, can be merged or should be dropped?

akobel commented 7 years ago

Closed "by accident", while rebasing to the current master. This is still relevant.

I use the lilypond-version-predicates now. Still no docs, though, just a mini-fix in the source.