openlilylib / snippets

A place to store useful pieces of LilyPond code - custom functions, engravers, hacks, templates, examples etc.
Other
119 stars 39 forks source link

Tablature library: add the bending module #141

Closed fedelibre closed 8 years ago

fedelibre commented 8 years ago

I've merely copied and adapted the snippet in notation-snippets/guitar-string-bending/.

I have a question regarding version changes. In the bend.ly example there's a commented line where microtone bendings are used. In order for this to work, I should load also the microtones module for versions below 2.19.31 or change the example for versions >=2.19.31. How to handle such a situation?

By the way, I was not able to load two modules:

\useLibrary Tablature
\useModule tablature.bending
\useModule tablature.microtones
uliska commented 8 years ago

Can't test now. But please try putting (display "")

between the two \useModule calls.

Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

fedelibre commented 8 years ago

Yes, adding that line worked. What about the version to be used for microtones? I would update it to >= 2.19.31. This library is meant for people who can use git and are able to go back to previous version if needed.

I'll need to change it soon to 2.19.31 for my personal use. Let me know if I should keep it on my local branch or send a new PR.

fedelibre commented 8 years ago

well, actually I should change only the example for >=2.19.31:

  1. remove the include of tablature.microtones
  2. add this to \layout:
\layout {
  \context {
    \Score
    noteToFretFunction = #(determine-frets #t)
  }
}
fedelibre commented 8 years ago

@uliska I've pulled your changes and I see that now it compiles fine with 2.19.31. I think that you can revert the debug output introduced in 5f82c58c19e2e6fb4f0616d5bf63ae1a0d5c14de and merge it.

What about the example version? What's the policy for the snippets? They should be for the latest stable, if possible? If so, I should update it when 2.20 is released?

uliska commented 8 years ago

I have now reverted that debug output and added source comments about the fact that I don't consider the "cure" a proper one.

With regard to the example's version I have to admit that I never really thought about that. But your reasoning looks convincing.

fedelibre commented 8 years ago

For the records, the setting to enable microtones in TabStaff is now this:

\layout {
  \context {
    \Score
    supportNonIntegerFret = ##t
  }
}