initial commit - Githubissues

andrewbernard commented 8 years ago

Initial code for \slashBeam function.

uliska commented 8 years ago

Some comments (in addition to the very nice example file):

It seems the angle is actually reversed for right slashes. So a 60 on a right slash actually means the slash is sloped 60 degrees downwards (i.e. actually -60 or +300 degrees). If I'm not completely mistaken with this it should be mentioned in the documentation.
I can see why you didn't start working on defaults and storing values. However, I'd strongly suggest to make at least the <side> argument optional (pulling it to the first position) and let it default to 'left.
If you want to leave your email address in it you can simply add a snippet-author-email field. This isn't used so far, but I find it's a good idea to have for the future.

uliska commented 8 years ago

I will wait with merging until you implement the 'left default. Maybe one shouldn't merge when you already know that the input syntax will soon change.

Anything else on the wish- or todo-lists are not an issue with merging IMO.

uliska commented 7 years ago

Hi @andrewbernard ,

sorry that I have completely forgotten about this PR. I've added the check for 'left and 'right as suggested by my previous comment and merged it now.

openlilylib / snippets

initial commit #149