search

openlilylib / snippets

A place to store useful pieces of LilyPond code - custom functions, engravers, hacks, templates, examples etc.
Other
120 stars 38 forks source link

Add options to choose text typefaces together with the notation font. #150

Closed mrtnnbr closed 8 years ago

mrtnnbr commented 8 years ago

Allows redefining the default typefaces in one place: \useNotationFont \with { roman = "Times New Roman" sans = "Nimbus Sans" typewriter = "Luxi Mono" } Gonville

uliska commented 8 years ago

Thank you for the PR. Looks pretty good (although only having read it in the web interface).

One thing you might want to reconsider is the handling of defaults is pretty redundant (which may partly be due to the existing code). Defaults are set in the registerOption, then in the function interface and once more in the actual \useNotationFont routine. (Note that with brace it's different because this has to fall back to the main font). You (or we (if I manage to get back to this before you ...)) should think about a more efficient and straightforward approach.

mrtnnbr commented 8 years ago

Hi Urs,

Thanks for the comment. Indeed, it seems the registerOption block is sufficient. During my first attempts there were some funky issues when not providing alternatives for all font families in the score. I didn't like the verbosity much myself, but was still (wrongly) under the impression that would be necessary. I'll fix this in a moment and re-submit.