search

openlilylib / snippets

A place to store useful pieces of LilyPond code - custom functions, engravers, hacks, templates, examples etc.
Other
119 stars 39 forks source link

pedal decorations now takes account of short segments #157

Closed andrewbernard closed 7 years ago

andrewbernard commented 7 years ago

Code improved so that if there is no room on the left of the pedal bracket for a label due to on/off events then it is not drawn.

uliska commented 7 years ago

I don't really see what this changes.

But I don't see any problems so you may merge this one yourself or add an example that shows the difference (or if the file already does this please add some hint)

andrewbernard commented 7 years ago

HI Urs,

There was an issue where if there is a ‘^’ at the very start of the line or close to it the label would overwrite it. Now the code checks that and does not put a label in that case. A small change, but important.

Andrew

From: Urs Liska [mailto:notifications@github.com] Sent: Wednesday, 23 November 2016 1:10 AM To: openlilylib/snippets snippets@noreply.github.com Cc: Andrew Bernard andrew.bernard@gmail.com; Author author@noreply.github.com Subject: Re: [openlilylib/snippets] pedal decorations now takes account of short segments (#157)

I don't really see what this changes.

But I don't see any problems so you may merge this one yourself or add an example that shows the difference (or if the file already does this please add some hint)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openlilylib/snippets/pull/157#issuecomment-262249702 , or mute the thread https://github.com/notifications/unsubscribe-auth/AD0u-08aQSyMfyQ0IlMTMn3yBGIhT5__ks5rAvepgaJpZM4K5LPf . https://github.com/notifications/beacon/AD0u-yBtV7xlLnvUz_QXPNqeKLDpFn1nks5rAvepgaJpZM4K5LPf.gif

uliska commented 7 years ago

Ok, that's nothing that requires a mention.