search

openlilylib / snippets

A place to store useful pieces of LilyPond code - custom functions, engravers, hacks, templates, examples etc.
Other
119 stars 39 forks source link

Some edits during gridly review #84

Closed uliska closed 9 years ago

uliska commented 9 years ago

While reviewing the gridly/development branch I did some edits.

Most notably:

There's a TODO remark in https://github.com/openlilylib/openlilylib/commit/814e1958f025ca68be72bf4bbe233f60647a1050 which I can't resolve myself.

One more thing I noticed but which doesn't go into this PR: The example file doesn't cover everything for test cases: There are two commented lines with different \gridSetRange commands that aren't part of the automated tests.

To deal with this situation I suggest splitting up the examples in multiple ones: one defining the grid and separate ones to cover the different commands.

Apart from the commits in this PR I'm OK with the branch, so please merge this into gridly/development and then into master

uliska commented 9 years ago

The build tests are strange because this branch is still confused about the renamed test-excludes file, but I think this is not an issue for merging.

Cecca commented 9 years ago

Ok, thanks for that edits. I'll take care of that TODO item