search

openlink / html5pivotviewer

The HTML5 PivotViewer is a fork of a project that was started by LobsterPot Solutions as a cross browser, cross platform version of the Silverlight PivotViewer control produced by Microsoft. The control was written as a jQuery plug-in and utilises features available in HTML5.
Other
115 stars 79 forks source link

Resize Browser #13

Open johntom opened 10 years ago

johntom commented 10 years ago

Hi, I've just tried your html5 viewer and I'm very happy with my initial results. See sample2.gtz.com for a collection of mostly photgrahps by Nina Meledandi. One issue is that the collection will always size to the orginal size of browser. For example,if you open the browser with a 5 inch width and then make it 9 inches the main image panel does not grow unless you reload the page. Thanks much for all your work as this seems to be getting close to the Silverlight version and all things considered is quite impressive. John

mattleibow commented 10 years ago

Hi, I am also going to have a problem with this. I'll have a look and see what needs doing... Or, has someone fixed this somewhere?

mattleibow commented 10 years ago

I have done some work on this. It was fairly straightforward, instead of passing the height and width to the View, I pass instead a function that is executed each time. This allows for the different sizes to be used in calculations.

I need to still find an easier way to contain the code for resizing the various controls. Originally, the height was fixed and the sidebars, headers, etc were pre-calculated, now they are dynamic. This is resulting in logic that assumed various heights to be come a bit off. (there are several places with "magic numbers" - hardcoded heights and widths)

Hopefully I will be able to commit something soon for feedback.

johntom commented 10 years ago

Thanks. 

Sent via the Samsung Galaxy S™III, an AT&T 4G LTE smartphone

-------- Original message -------- From: Matthew Leibowitz notifications@github.com Date: 11/24/2013 3:43 PM (GMT-05:00) To: openlink/html5pivotviewer html5pivotviewer@noreply.github.com Cc: "John R. Tomaselli" jrt@gtz.com Subject: Re: [html5pivotviewer] Resize Browser (#13)

I have done some work on this. It was fairly straightforward, instead of passing the height and width to the View, I pass instead a function that is executed each time. This allows for the different sizes to be used in calculations.

I need to still find an easier was to contain the code for resizing the various controls. Originally, the height was fixed and the sidebars, headers, etc were pre-calculated, now they are dynamic. This is resulting in logic that assumed various heights to be come a bit off.

Hopefully I will be able to commit something soon for feedback.

— Reply to this email directly or view it on GitHub.

No virus found in this message. Checked by AVG - www.avg.com Version: 2014.0.4158 / Virus Database: 3629/6851 - Release Date: 11/20/13

mattleibow commented 10 years ago

Ok, I have committed the first go at implementing the resize - you can see my fork. It is not complete yet - only the grid view works. I will be working on this this week. Any feedback is cool :) Let me know if you have any problems.

mattleibow commented 10 years ago

I have finished the next view now, bars, as well as some small bug fixes...

mattleibow commented 10 years ago

@johntom I have finished the changes needed to do the resize, you can use my fork, or wait for the changes to be merged.

dpituerdesign commented 10 years ago

Great fork, I use your resize version an it works very well.