search

openlink / html5pivotviewer

The HTML5 PivotViewer is a fork of a project that was started by LobsterPot Solutions as a cross browser, cross platform version of the Silverlight PivotViewer control produced by Microsoft. The control was written as a jQuery plug-in and utilises features available in HTML5.
Other
113 stars 116 forks source link

Selection Handling #36

Open ghost opened 9 years ago

ghost commented 9 years ago

The selection handling code in both gridview.js and graphview.js includes a lot of variables not explicitly declared with "var." While this doesn't seem to cause problems at the moment, this is probably something that should be fixed.

ghost commented 9 years ago

Also, both files make use of the line

if (selectedItem != null && selectedTile != null) {

It's within that scope that many of the aforementioned variables are first used and set. Given that the code following that scope makes use of those values, the code as it now stands is banking on the fact that that if statement will never be false.